Skip to content

Skip OVN checks in minor update when OVN is disabled#1744

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
dprince:ovn_minor_update_check
Dec 22, 2025
Merged

Skip OVN checks in minor update when OVN is disabled#1744
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
dprince:ovn_minor_update_check

Conversation

@dprince
Copy link
Copy Markdown
Contributor

@dprince dprince commented Dec 19, 2025

Fixes a bug where the minor update sequence would hang when OVN is disabled. The controller was checking OVN conditions that don't exist when OVN is not enabled, causing the update process to stall.

Changes:

  • Add Ovn.Enabled checks before OVN image and condition validation
  • Skip OVN controlplane and dataplane update checks when disabled
  • Add comprehensive functional test for minor updates with OVN disabled

Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com

Jira: OSPRH-23103

Fixes a bug where the minor update sequence would hang when OVN
is disabled. The controller was checking OVN conditions that don't
exist when OVN is not enabled, causing the update process to stall.

Changes:
- Add Ovn.Enabled checks before OVN image and condition validation
- Skip OVN controlplane and dataplane update checks when disabled
- Add comprehensive functional test for minor updates with OVN disabled

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Jira: OSPRH-23103
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from abays and stuggi December 19, 2025 15:37
@dprince
Copy link
Copy Markdown
Contributor Author

dprince commented Dec 19, 2025

when this lands on main we need to propose a backport to FR4

@dprince
Copy link
Copy Markdown
Contributor Author

dprince commented Dec 19, 2025

/test openstack-operator-build-deploy-kuttl

1 similar comment
@lmiccini
Copy link
Copy Markdown
Contributor

/test openstack-operator-build-deploy-kuttl

@lmiccini
Copy link
Copy Markdown
Contributor

/lgtm

@lmiccini
Copy link
Copy Markdown
Contributor

/cherry-pick 18.0-fr4

@openshift-cherrypick-robot
Copy link
Copy Markdown

@lmiccini: once the present PR merges, I will cherry-pick it on top of 18.0-fr4 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick 18.0-fr4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit c5c4018 into openstack-k8s-operators:main Dec 22, 2025
8 checks passed
@openshift-cherrypick-robot
Copy link
Copy Markdown

@lmiccini: new pull request created: #1749

Details

In response to this:

/cherry-pick 18.0-fr4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@karelyatin
Copy link
Copy Markdown
Contributor

/lgtm also did a testpatch for non ovn minor update and went fine
cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5c53482152714db59fbd9175645975a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants